[PATCH] D91152: [obj2yaml] - Dump section offsets in some cases.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 04:54:10 PST 2020


grimar added a comment.

In D91152#2388303 <https://reviews.llvm.org/D91152#2388303>, @jhenderson wrote:

> Mostly looks fine. Do NOBITS sections come into play here at all? In particular, their size wouldn't normally impact the offset of subsequent sections.

I've updated the patch and added the test case for SHT_NOBITS sections. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91152/new/

https://reviews.llvm.org/D91152



More information about the llvm-commits mailing list