[PATCH] D91250: Support intrinsic overloading on anonymous struct based types

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

In D91250#2388377 <https://reviews.llvm.org/D91250#2388377>, @fhahn wrote:

> Is this the same idea as in D48541 <https://reviews.llvm.org/D48541> (linked from PR38117), where we use LLVMContext to keep track of IDs for anonymous types? If that's the case, the same objections as for D48541 <https://reviews.llvm.org/D48541> probably apply here as well. I think one of the problems is that the names we assign depend on the order different modules are loaded.

Somehow I missed that one before.. But yes, the current implementation will suffer the same problem. Moving the DenseMap from LLVMContext to Module should resolve that problem ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91250/new/

https://reviews.llvm.org/D91250