[PATCH] D91152: [obj2yaml] - Dump section offsets in some cases.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Mostly looks fine. Do NOBITS sections come into place here at all? In particular, their size wouldn't normally impact the offset of subsequent sections.



================
Comment at: llvm/test/tools/obj2yaml/ELF/offset.yaml:86
+## Show we dump the "Offset" key for the first section when
+## it has a non expected file offset.
+
----------------



================
Comment at: llvm/test/tools/obj2yaml/ELF/offset.yaml:99
+
+## Test that we take the alignment of the first section in account
+## when calculating the expected offset for it. In this case we don't
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91152/new/

https://reviews.llvm.org/D91152