[PATCH] D91127: [ELF] Use input order instead of pattern order within an input section description

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 03:17:26 PST 2020


psmith added inline comments.


================
Comment at: lld/ELF/LinkerScript.cpp:482
+    // Matched sections by this SORT pattern are sorted by SORT* commands,
+    // breaking tie by position. ret[sizeBeforePat,ret.size()) are already in
+    // the position order, so we just sort by sortOuter and sortInner.
----------------
Thanks for the update, I think the new names are much better. One small nit, I think in sizeBeforePat should be sizeBeforeCurrPat in
```
ret[sizeBeforePat,ret.size())
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91127/new/

https://reviews.llvm.org/D91127



More information about the llvm-commits mailing list