[PATCH] D77384: [WebAssembly] Support single-floating-point immediate value

Yuta Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 21:53:03 PST 2020


kateinoigakukun updated this revision to Diff 304397.
kateinoigakukun added a comment.
Herald added subscribers: ecnelises, kerbowa, nhaehnle, jvesely, arsenm.

> Having createFPImm and createSFPImm (similarly for the add methods) seems confusing. Can we not have a uniform SFP/DFP split in the names everywhere, since you're already touching the uses of the former due to changing the types?

I updated to have a uniform SFP/DFP in floating-point APIs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77384/new/

https://reviews.llvm.org/D77384

Files:
  llvm/include/llvm/MC/MCInst.h
  llvm/include/llvm/MC/MCInstBuilder.h
  llvm/lib/MC/MCInst.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
  llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
  llvm/lib/Target/ARM/ARMMCInstLower.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
  llvm/lib/Target/AVR/MCTargetDesc/AVRMCCodeEmitter.cpp
  llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
  llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td
  llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  llvm/test/CodeGen/WebAssembly/immediates.ll
  llvm/test/CodeGen/WebAssembly/snan_literal.ll
  llvm/tools/llvm-exegesis/lib/BenchmarkResult.cpp
  llvm/tools/llvm-exegesis/lib/MCInstrDescView.cpp
  llvm/unittests/tools/llvm-exegesis/X86/BenchmarkResultTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77384.304397.patch
Type: text/x-patch
Size: 20156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201111/6420038b/attachment.bin>


More information about the llvm-commits mailing list