[PATCH] D91160: [NFC] Use [MC]Register for Hexagon target

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 20:39:46 PST 2020


mtrofin added a comment.

In D91160#2387274 <https://reviews.llvm.org/D91160#2387274>, @gjain wrote:

> I'd definitely prefer not cleaning up RegisterRef as part of this patch. The register/sub tuple pattern is present throughout the code and needs an independant clean-up. Otherwise we risk this not being a NFC.
>
> Regarding const usage, this will delete the implicit copy constructor. Given the earlier statement that those classes need an independant clean-up, are you okay punting on this?

Yes, but could you add a FIXME above each, with the same text - so we can fish them out easily afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91160/new/

https://reviews.llvm.org/D91160



More information about the llvm-commits mailing list