[PATCH] D91188: Add !annotation metadata and remarks pass.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 17:24:26 PST 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp:48
+  for (auto &KV : Mapping)
+    ORE.emit(OptimizationRemarkMissed(REMARK_PASS, "AnnotationSummary",
+                                      &*F.begin()->begin())
----------------
thegameg wrote:
> Any reason this is a "missed" remark and not "analysis"?
Yeah, I didn't notice this. Missed is not good. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91188/new/

https://reviews.llvm.org/D91188



More information about the llvm-commits mailing list