[PATCH] D91127: [ELF] Use input order instead of pattern order within an input section description

[Peter Smith via Phabricator via llvm-commits]

psmith added a comment.

It took a lot of staring at that bit of code to work out what was going on. If I have understood it correctly. In particular I got confused with the sizeBefore and sizeLastSort with sizeBefore being the larger value. It took me a while to spot the continue. If I've understood correctly:

- sizeBefore is really sizeOfRetBeforeNextSort
- sizeLastSort is really sizeOfRetAfterPreviousSort

If possible could we use Prev rather than Last as it is more specific. Last can mean the last one we went by, or the last one in the list. I strongly recommend adding something like Next to sizeBefore so that it is clear that sizeBefore >= sizeLastSort.

It would be good to write a comment explaining how the partitions work as there are a lot of sorts, some of the indices and some of the sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91127/new/

https://reviews.llvm.org/D91127