[PATCH] D91125: [AArch64][GlobalISel] Port some AArch64 target specific MUL combines from SDAG.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:225
+    }
+    // B.buildCopy(DstReg, Res.getReg(0));
+    Res->getOperand(0).setReg(DstReg);
----------------
paquette wrote:
> aemerson wrote:
> > paquette wrote:
> > > Remove?
> > This should probably actually be the copy, since we shouldn't be modifying an instruction without notifying the observer.
> I guess ApplyFn could take in the observer as an argument, or `appleAArch64MulConstCombine` could notify the observer around the call?
Yeah. It’s a bit annoying that we have to pass all this into each match/apply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91125/new/

https://reviews.llvm.org/D91125