[PATCH] D91180: [ELF] Support multiple SORT in an input section description

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 14:25:39 PST 2020


psmith added a comment.

Looks OK to me. Will be best to see if George has any comments about how to do the parsing.



================
Comment at: lld/ELF/ScriptParser.cpp:645
 // any file but a.o, and section .baz in any file but b.o.
 std::vector<SectionPattern> ScriptParser::readInputSectionsList() {
   std::vector<SectionPattern> ret;
----------------
May be worth adding a SORT example here, as peek2() may look a bit strange without one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91180/new/

https://reviews.llvm.org/D91180



More information about the llvm-commits mailing list