[PATCH] D90776: [FastISel] Sink more materializations to first use

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 13:41:51 PST 2020


rnk added a comment.

Thanks for gathering the measurements! They seem promising.

I apologize for passing the work of measuring on to you. I think the last time I looked at this, I felt it would be easier (faster?) to code up the "local value sinking" feature than to run measurements and gather consensus to disable local value reuse. But, that was probably not the best tradeoff in the long run. Less code is better than more code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90776/new/

https://reviews.llvm.org/D90776



More information about the llvm-commits mailing list