[PATCH] D91115: [lld][WebAssembly] Allow references to __tls_base without shared memory
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 10 12:39:10 PST 2020
sbc100 added inline comments.
================
Comment at: lld/wasm/Driver.cpp:664
+ if (!config->sharedMemory)
+ WasmSym::tlsBase = createOptionalGlobal("__tls_base", false, 0);
}
----------------
tlively wrote:
> Is `0` the start of the static data region?
No, these globals are all set later on `Writer.cpp` .. this was just a zero-init. It was a little confusing though so I removed this final argument for all callers (since none of them have non-zero init that are useful).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91115/new/
https://reviews.llvm.org/D91115
More information about the llvm-commits
mailing list