[PATCH] D90884: [SmallVector] Add a default small size.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 12:24:40 PST 2020


silvas added a comment.

In D90884#2386770 <https://reviews.llvm.org/D90884#2386770>, @tschuett wrote:

> I thought the other way around. Don't use a default size, but fix cases of misuse.

That's another approach. The downside is:

1. loses on the convenience of having a default SmallSize
2. cases of misuse are continuously being added, so this is a constant maintenance task
3. once we fix the big low hanging fruit, performance issues due to small size choices can be "death by 1000 papercuts", so meaningful tuning can only happen in aggregate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90884/new/

https://reviews.llvm.org/D90884



More information about the llvm-commits mailing list