[PATCH] D91188: Add !annotation metadata and remarks pass.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp:47
+
+  for (auto &KV : Mapping)
+    ORE.emit(OptimizationRemarkMissed(REMARK_PASS, "AnnotationSummary",
----------------
Can this be `const`?


================
Comment at: llvm/lib/Transforms/Scalar/AnnotationRemarks.cpp:49
+    ORE.emit(OptimizationRemarkMissed(REMARK_PASS, "AnnotationSummary",
+                                      &*F.begin()->begin())
+             << "Annotated " << NV("count", KV.second) << " instructions with "
----------------
Pull out of the loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91188/new/

https://reviews.llvm.org/D91188