[PATCH] D91046: [CGSCC][Inliner] Handle new non-trivial edges in updateCGAndAnalysisManagerForPass

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:550-551
     // TODO: This only allows trivial edges to be added for now.
     assert((RC == &TargetRC ||
            RC->isAncestorOf(TargetRC)) && "New call edge is not trivial!");
+    // Add a trivial ref edge to be promoted later on alongside
----------------
As a side note, this assert was previously incorrect, it should have checked the two SCCs, not RefSCCs. With this change this is now what we actually want to assert. For example, it didn't catch the added test, instead a later assert triggered on the added test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91046/new/

https://reviews.llvm.org/D91046