[PATCH] D91174: [Analysis] Introduce a new InstructionCost class
Chris Lattner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 10 09:02:39 PST 2020
lattner added a comment.
Looks reasonable to me!
================
Comment at: llvm/include/llvm/Analysis/InstructionCost.h:20
+
+#include "llvm/Support/raw_ostream.h"
+
----------------
I think you can forward declare raw_ostream. Please do: it is a relatively heavy header and IO doesn't need to be inlined.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91174/new/
https://reviews.llvm.org/D91174
More information about the llvm-commits
mailing list