[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 08:04:41 PST 2020


Sorry, I misread your original email: you're saying: use lit.local.cfg to
blanket-set the "don't allow unused prefixes" behavior on conforming
directories (I read it backwards).

I *think* the main challenge is that the -allow-unused-prefixes flag must
occur only once?

On Tue, Nov 10, 2020 at 7:51 AM Simon Pilgrim via Phabricator <
reviews at reviews.llvm.org> wrote:

> RKSimon added a comment.
>
> In D90281#2385772 <https://reviews.llvm.org/D90281#2385772>, @mtrofin
> wrote:
>
> > lit.local.cfg would "blanket-allow" future tests, too. Would that be
> desirable?
>
> Yes I'm finding that 99% of llvm tests that were failing were just poor
> check-prefix setup (usually copy+paste or too much emphasis on an
> unnecessarily complex prefix hierarchy) - so until you can flip the default
> value in FileCheck itself we should be able to use lit.local.cfg files in
> the subfolder root to keep them clean once they've been fixed up.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D90281/new/
>
> https://reviews.llvm.org/D90281
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201110/c953dab3/attachment.html>


More information about the llvm-commits mailing list