[PATCH] D91161: [NFC] Use [MC]Register for x86 target

Gaurav Jain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 07:46:15 PST 2020


gjain added inline comments.


================
Comment at: llvm/lib/Target/X86/X86DomainReassignment.cpp:223
     Register DstReg = MI->getOperand(0).getReg();
-    if (Register::isPhysicalRegister(DstReg) &&
-        (X86::GR8RegClass.contains(DstReg) ||
-         X86::GR16RegClass.contains(DstReg)))
+    if (DstReg.isPhysical() && (X86::GR8RegClass.contains(DstReg) ||
+                                X86::GR16RegClass.contains(DstReg)))
----------------
mtrofin wrote:
> what type is X86::GR8RegClass?
I believe it is TargetRegisterClass


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91161/new/

https://reviews.llvm.org/D91161



More information about the llvm-commits mailing list