[PATCH] D90734: [EarlyCSE] make abs recognization not depend on instcombine abs canonicalize

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 06:19:42 PST 2020


shchenz added a comment.

In D90734#2385565 <https://reviews.llvm.org/D90734#2385565>, @shchenz wrote:

> I am thinking `llvm.abs(A)` and `llvm.abs(-A)` can not be optimized in current earlyCSE phase? There are logics for commutative intrinsics and intrinsics with same operands in EarlyCSE pass. Am I missing something?

Ah, I know your ideas ^-^. Instcombine should canonicalize `llvm.abs(-A)` to `llvm.abs(A)`. So after instcombine, in earlycse, we will not see `llvm.abs(-A)` right? I don't have other concerns. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90734/new/

https://reviews.llvm.org/D90734



More information about the llvm-commits mailing list