[PATCH] D90880: [LoopVectorizer] NFC: Return ElementCount from compute[Feasible]MaxVF

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5275
+      UserIC ? MaxVF.getKnownMinValue() * UserIC : MaxVF.getKnownMinValue();
   if (TC > 0 && TC % MaxVFtimesIC == 0) {
     // Accept MaxVF if we do not have a tail.
----------------
dmgreen wrote:
> Would this TC mod check still be valid for scalable vectors? If not does it need an assert?
Good spot, you're right that this shouldn't work yet for scalable vectors. I've added an assert here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90880/new/

https://reviews.llvm.org/D90880