[PATCH] D91152: [obj2yaml] - Dump section offsets in some cases.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 05:37:27 PST 2020


jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

I don't think you want to set the offset unconditionally for the first section either. Much of the time the first section's position will be automatically derivable, namely immediately after the ELF header and potential program headers (after alignment has been taken into account). If we explicitly print the offset, people are going to start including it unnecessarily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91152/new/

https://reviews.llvm.org/D91152



More information about the llvm-commits mailing list