[PATCH] D90036: [AMDGPU] Emit stack frame size in metadata

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 304149.
sebastian-ne added a comment.

Rebase and add test with multiple allocations.

Summarizing comments here and via email:

- This does not work for dynamic allocations, e.g. in loops
- Our frontend for the pal subtarget (llpc) does currently not generate dynamic allocations and will not in the foreseeable future
- We could emit another field when we encounter dynamic allocations but this premature at this time
- We already use the same way to compute scratch size for entrypoint shaders

I hope this is good to go then.

We might need similar fields for LDS usage of functions but I don’t know the needed format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90036/new/

https://reviews.llvm.org/D90036

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.h
  llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h
  llvm/test/CodeGen/AMDGPU/amdpal-callable.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90036.304149.patch
Type: text/x-patch
Size: 12202 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201110/62ef7c33/attachment.bin>