[PATCH] D90734: [EarlyCSE] make abs recognization not depend on instcombine abs canonicalize

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 05:04:39 PST 2020


spatel added a comment.

In D90734#2384460 <https://reviews.llvm.org/D90734#2384460>, @shchenz wrote:

> @spatel updated. I guess we need to add abs handling later in earlycse pass after D87188 <https://reviews.llvm.org/D87188> is committed?

I am not seeing what we would need to do with this pass - if we canonicalize to the intrinsic form, then CSE just becomes a simple match of the intrinsic arguments. 
Do you have an example of something that would fail to optimize or hash properly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90734/new/

https://reviews.llvm.org/D90734



More information about the llvm-commits mailing list