[PATCH] D90942: [SVE][CodeGen] Improve codegen of scalable masked scatters
    Sander de Smalen via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Nov 10 04:13:45 PST 2020
    
    
  
sdesmalen added a comment.
The indentation seems off for some of the changes, could you run the patch through `clang-format`?
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9383
+  SDValue LHS = Index.getOperand(0);
+  if (LHS.getOpcode() != ISD::SPLAT_VECTOR)
+    return false;
----------------
This should probably use `SelectionDAG::getSplatValue()` instead, because there are multiple ways of representing splats (SPLAT_VECTOR is only used for scalable vectors at the moment).
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90942/new/
https://reviews.llvm.org/D90942
    
    
More information about the llvm-commits
mailing list