[PATCH] D90941: [SVE][CodeGen] Lower scalable masked scatters

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Can you please run your patch through clang-format?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1869
+     N->setIndexType(TLI.getCanonicalIndexType(N->getIndexType(),
+                                               N->getMemoryVT(), NewOps[OpNo]));
   } else {
----------------
nit: indentation seems off.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2542
   SDValue OpsLo[] = {Ch, DataLo, MaskLo, Ptr, IndexLo, Scale};
-  Lo = DAG.getMaskedScatter(DAG.getVTList(MVT::Other), DataLo.getValueType(),
+  Lo = DAG.getMaskedScatter(DAG.getVTList(MVT::Other), LoMemVT,
                             DL, OpsLo, MMO, N->getIndexType(),
----------------
should these change here in `SplitVecOp_MSCATTER` be part of D90939?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7442
+                                          SDValue Offsets) const {
+  bool isScaledIndex = (IndexType == ISD::SIGNED_SCALED) ||
+                       (IndexType == ISD::UNSIGNED_SCALED);
----------------
nit: Please change these names to match LLVM's coding style, as suggested by clang-tidy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90941/new/

https://reviews.llvm.org/D90941