[PATCH] D89847: [SCEV] Drop cached ranges of AddRecs after flag update
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 9 21:00:27 PST 2020
mkazantsev added inline comments.
================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5520
+ if (AddRec->getNoWrapFlags(Flags) != Flags) {
+ assert(AddRec->getNoWrapFlags(Flags) <= Flags && "Pessimizing AddRec flags?");
+ AddRec->setNoWrapFlags(Flags);
----------------
mkazantsev wrote:
> I realized it's not the right way to check it since the assert may never fail.
Actually, `setNoWrapFlags` does not drop previous flags, so this assert is just pointless. I'll remove it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89847/new/
https://reviews.llvm.org/D89847
More information about the llvm-commits
mailing list