[PATCH] D58951: [compiler-rt][tests] Improve handling with non-default toolchains

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: compiler-rt/test/lit.common.configured.in:10
 set_default("target_triple", "@COMPILER_RT_DEFAULT_TARGET_TRIPLE@")
-set_default("target_cflags", "@COMPILER_RT_TEST_COMPILER_CFLAGS@")
+set_default("target_cflags", "@COMPILER_RT_TOOLCHAIN_CFLAGS@")
 set_default("host_arch", "@HOST_ARCH@")
----------------
oontvoo wrote:
> + @vitalybuka
> 
> This `COMPILER_RT_TEST_COMPILER_CFLAGS` is used by our [[ https://github.com/llvm/llvm-zorg/blob/4c5df5edfb4b1c7209354a6d871118adc3fea2f1/zorg/buildbot/builders/sanitizers/buildbot_android_functions.sh#L108 | bots ]]
> Should it be changed?
> 
> 
Please see change in this patch to `compiler-rt/cmake/base-config-ix.cmake`. `COMPILER_RT_TEST_COMPILER_CFLAGS` is respected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58951/new/

https://reviews.llvm.org/D58951