[llvm] 0f62f05 - Revert "[llvm] CMake: Force MSVC to read code as UTF-8"

Kirill Bobyrev via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 14:04:27 PST 2020


Author: Kirill Bobyrev
Date: 2020-11-09T23:04:16+01:00
New Revision: 0f62f05655d0dc879bd822b7808f1d3120155e6b

URL: https://github.com/llvm/llvm-project/commit/0f62f05655d0dc879bd822b7808f1d3120155e6b
DIFF: https://github.com/llvm/llvm-project/commit/0f62f05655d0dc879bd822b7808f1d3120155e6b.diff

LOG: Revert "[llvm] CMake: Force MSVC to read code as UTF-8"

This reverts commit 4d81c8adb6ed9840257f6cb6b93f60856d422a15.

Apparently, we have code that indirectly uses #pragma
execution_character_set which depends on utf-8 not being set:

http://lab.llvm.org:8011/#/builders/127/builds/1161/steps/4/logs/stdio

Added: 
    

Modified: 
    llvm/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 0c9c4cd1969b..21563e151180 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -599,8 +599,6 @@ if(MSVC)
   if (BUILD_SHARED_LIBS)
     message(FATAL_ERROR "BUILD_SHARED_LIBS options is not supported on Windows.")
   endif()
-  # Force MSVC to read code as UTF-8.
-  add_compile_options(/utf-8)
 else()
   option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
   option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)


        


More information about the llvm-commits mailing list