[PATCH] D90977: [Coroutine] Move all used local allocas to the .resume function

Mon Nov 9 13:07:28 PST 2020

lxfind added a comment.

In D90977#2383607 <https://reviews.llvm.org/D90977#2383607>, @ben-clayton wrote:

> I can confirm that this fixes the crash we've been seeing - thank you!

Cool. I also noticed that your code have quite lots of allocas, which makes it a great example to benchmark the effect of memory savings from D89768 <https://reviews.llvm.org/D89768>.
I was wondering, comparing to before D89768 <https://reviews.llvm.org/D89768> and now, how much reduction do you see in the coroutine frame size in your codebase (i.e. the eventual argument to @coroutine_alloc_frame)? I would really appreciate if you could share some insights on the magnitude of that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90977/new/

https://reviews.llvm.org/D90977