[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 13:05:45 PST 2020


ldionne added a comment.

In D42459#2383794 <https://reviews.llvm.org/D42459#2383794>, @hintonda wrote:

> In D42459#2383753 <https://reviews.llvm.org/D42459#2383753>, @ldionne wrote:
>
>> @hintonda  Is there a reason why this was done except for "standardizing the usage across projects"?
>
> It was just for standardization.  Please feel free to rollback or modify as necessary.

Ok, thanks a lot for the information. If things worked before, I would like to revert this change as we are working around it in our internal build, and it just bit me today. I'll send a review.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42459/new/

https://reviews.llvm.org/D42459



More information about the llvm-commits mailing list