[PATCH] D89847: [SCEV] Drop cached ranges of AddRecs after flag update

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 12:38:01 PST 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

In D89847#2381786 <https://reviews.llvm.org/D89847#2381786>, @mkazantsev wrote:

> Added elaborate comment, added assert that we don't pessimize the flags.
>
> For some reason, it's no longer helpimg srem.ll. There has been a lot of related patches merged, one of them broke it?

I'm not sure, but I think @nikic had some patches that delay the flag computation in some cases, so maybe this caused the changes there?

Patch LGTM, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89847/new/

https://reviews.llvm.org/D89847



More information about the llvm-commits mailing list