[PATCH] D90940: [LoopFlatten] Make it a FunctionPass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopFlatten/loop-flatten-negative.ll:404
+;
+define dso_local void @d3_1(i32* %A, i32 %N) local_unnamed_addr #0 {
+entry:
----------------
dmgreen wrote:
> None of these are flattened? Any idea why?
> 
> You can remove dso_local  and local_unnamed_addr #0 
> None of these are flattened? Any idea why?

Yeah, looks like there's room for improvement. They are rejected for different reasons:

- `Did not match expected pattern, bailing`
- `Cannot flatten because instruction may have side effects`
- Might overflow, to be addressed in a next patch,




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90940/new/

https://reviews.llvm.org/D90940