[PATCH] D89566: [LV] Epilogue Vectorization with Optimal Control Flow

Mon Nov 9 10:51:23 PST 2020

SjoerdMeijer added a comment.

My observations here are:

- Performance of both patches for SPEC are the same. The advantage of D88819 <https://reviews.llvm.org/D88819> on ThunderX2 might be a coincidence (knock on effect, e.g. (loop) alignment) or some micro-architecture reason.
- This patch D89566 <https://reviews.llvm.org/D89566> can handle more loops, but it is not reflected in the SPEC numbers (cold/not executed code?).
- The beauty of D88819 <https://reviews.llvm.org/D88819> is that the changes are very minimal, but looks like it's worth spending extra lines of code here in D89566 <https://reviews.llvm.org/D89566> to helps in vectorising more.

To me, that shows there's more potential with this patch.
I don't think I can't be the arbiter in this, so it's best if other reviewers comment too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89566/new/

https://reviews.llvm.org/D89566