[PATCH] D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section.

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 10:00:33 PST 2020


rahmanl added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:1504
+    return "";
+  }
+
----------------
grimar wrote:
> Oh. This piece is actually not needed anymore, we have a general mechanism for validating fields.
> I've committed rGc9d036ad4a2962059c595c77abb51154e2f5ec27
Thanks for submitting the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88717/new/

https://reviews.llvm.org/D88717



More information about the llvm-commits mailing list