[PATCH] D90686: [lld][ELF] Add additional time trace categories

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: lld/ELF/Writer.cpp:207
 void elf::combineEhSections() {
+  llvm::TimeTraceScope timeScope("Combine exception sections");
   for (InputSectionBase *&s : inputSections) {
----------------
jhenderson wrote:
> MaskRay wrote:
> > EH is probably more appropriate than exception.
> > 
> > .gcc_except_table is not handled here.
> If by EH you mean specifically .eh_frame, then that would be misleading for those using ARM exidx instead? If it means something else, I'm not sure what it means.
EH can mean both .eh_frame and .ARM.exidx

The ARM ABI is called "Exception Handling ABI for the Arm Architecture". An alternative name is unwinding sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90686/new/

https://reviews.llvm.org/D90686