[PATCH] D88629: [lld-macho] Add ARM64 target arch

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Arch/ARM64.cpp:95-108
+  ARM64RelocAttrs &relocAttrs = arm64RelocAttrs[rel.r_type];
+  if (relocAttrs.externOnly && !rel.r_extern)
+    error(relocAttrs.name + " " + getErrorLocation(mb, sec, rel) +
+          " must be extern");
+  if (!(relocAttrs.lengths & (1 << rel.r_length))) {
+    SmallVector<StringRef, 4> lengthStrings{"0", "4", "8", "4 or 8"};
+    error(relocAttrs.name + " has length " + std::to_string(1 << rel.r_length) +
----------------
can we factor out the validation code into a separate function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88629/new/

https://reviews.llvm.org/D88629