[PATCH] D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM with nits on the comments.



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:154
+///
+/// \param V - The value to check for consistency.
+/// \param GVN - The global value number assigned to \p V.
----------------
Update param name in comments?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:185
+collectRegionsConstants(OutlinableRegion &Region,
+                       DenseMap<unsigned, Constant *> &GVNToConstant,
+                       DenseSet<unsigned> &NotSame) {
----------------
Parameter is not documented?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:265
+/// \param [in,out] Region - The region of code to be analyzed.
+/// \param [out] Inputs - The global value numbers for the extracted arguments.
+/// \param [out] ArgInputs - The values of the inputs to the extracted function.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86977/new/

https://reviews.llvm.org/D86977