[PATCH] D91038: [LoopIdiom] Introduce 'left-shift until bittest' idiom

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2081
+    return false;
+  }
+
----------------
jdoerfert wrote:
> Drive by: Should we move this "early exit" before step 2?
We can't do that, because we can't do this check before we've canonicalized the comparison predicate
(see previous `if`), which we can't do until after we've matched the bit-mask
(because in next patches said matching will result in other predicate changes)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91038/new/

https://reviews.llvm.org/D91038