[PATCH] D90933: [lld][ELF][test] Add additional --symbol-ordering-file testing

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 01:51:27 PST 2020


grimar added a comment.

Have a minor question/suggestion. The rest LG.



================
Comment at: lld/test/ELF/symbol-ordering-file.s:23
 # RUN: echo "_init2" >> %t_order.txt
 # RUN: echo "_init1" >> %t_order.txt
 
----------------
Does it make sence to test the mix of different line endings? I.e windows ("\r\n") vs linux ("\n")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90933/new/

https://reviews.llvm.org/D90933



More information about the llvm-commits mailing list