[PATCH] D90933: [lld][ELF][test] Add additional --symbol-ordering-file testing

[James Henderson via Phabricator via llvm-commits]

jhenderson marked 2 inline comments as done.
jhenderson added inline comments.


================
Comment at: lld/test/ELF/symbol-ordering-file.s:35
+
+# WARN: warning: {{.*}}duplicate ordered symbol
 
----------------
MaskRay wrote:
> 
Okay. I was deliberately trying to avoid testing the message in detail, since it somewhat duplicates coverage provided by symbol-ordering-file-warnings.s. Ideally, I'd not check it at all, but I want to show that there are no other warnings, caused by the whitespace/comments etc. However, I also don't want to lose the coverage given by the duplicate symbol (i.e. which one determines the order for that symbol). I'm open to alternative suggestions that would help with this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90933/new/

https://reviews.llvm.org/D90933