[PATCH] D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder

Mon Nov 9 01:33:35 PST 2020

AMDChirag added inline comments.

================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:787
+    ArrayRef<BodyGenCallbackTy> SectionCBs, PrivatizeCallbackTy PrivCB,
+    FinalizeCallbackTy FiniCB, bool IsCancellable, bool IsNoWait) {
+  if (!updateToLocation(Loc))
----------------
fghanim wrote:
> Where do you call the `FiniCB` callback? I cannot find it anywhere.
> 
> if not, then you probably should. this is where finalization code is done (e.g. destructors call + any other cleanup code)
> 
> At this stage, I am not sure if we need a single `Finicb` for the entire thing, or one per `SectionCB`.
Hi @fghanim 
Could you please tell me how the multiple FiniCB thing will work? Will there be separate definitions for the FiniCBs or the single definition (which is right now) will be used multiple times (= the number of section CBs)?
The frontend work has been added - revision D91054.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89671/new/

https://reviews.llvm.org/D89671