[PATCH] D91017: [BranchProbabilityInfo] Use SmallVector (NFC)

[Yevgeny Rouban via Phabricator via llvm-commits]

yrouban added subscribers: nikic, atrick.
yrouban added a comment.

This looks to be a good change towards simplification. I think originally a map over edges was introduced by @atrick back in 2011 in https://github.com/llvm/llvm-project/commit/49371f3f33788 as it could be sparse. But with the commit https://gitlab.azulsystems.com/dev/orca/commit/8138487468e22 we imposed an important restriction on setting outgoing edge probabilities at once for one block. This allowed correctness checks and further improvements like this.

As of performance impact of this patch I would suggest that you check llvm-compile-time-tracker.com <http://llvm-compile-time-tracker.com/about.php> out or contact @nikic directly.



================
Comment at: llvm/lib/Analysis/BranchProbabilityInfo.cpp:1175
+  DstProbs = SrcProbsIt->second;
   for (unsigned SuccIdx = 0; SuccIdx < NumSuccessors; ++SuccIdx) {
     LLVM_DEBUG(dbgs() << "set edge " << Dst->getName() << " -> " << SuccIdx
----------------
remove braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91017/new/

https://reviews.llvm.org/D91017