[PATCH] D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

OK. LGTM.



================
Comment at: flang/lib/Semantics/resolve-directives.cpp:830-831
 //
 // TODO: revisit after semantics checks are completed for do-loop association of
 //       collapse and ordered
 void OmpAttributeVisitor::PrivatizeAssociatedLoopIndex(
----------------
Nit: remove this todo.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:832
 //       collapse and ordered
 void OmpAttributeVisitor::PrivatizeAssociatedLoopIndex(
     const parser::OpenMPLoopConstruct &x) {
----------------
Nit: rename to PrivatizeLoopIndexAndCheckLoopLevel or a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89860/new/

https://reviews.llvm.org/D89860