[PATCH] D90660: [MemorySSA] Extend walker API taking in a MemoryLocation to take in a Stop access.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:966
+    MemoryAccess *StopAt =
+        (Stop && MSSA.dominates(Stop, Start)) ? Stop : nullptr;
     // This walker pretends uses don't exist. If we're handed one, silently grab
----------------
I would make `assert(!Stop || MSSA.dominates(Stop, Start))` a precondition for specifying the stop access. I don't think the intended semantics of a non-dominating stop point are clear, and I don't see an immediate use-case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90660/new/

https://reviews.llvm.org/D90660