[PATCH] D91005: [Reg2Mem] add support for the new pass manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 7 13:10:48 PST 2020


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

2 nits, otherwise lgtm



================
Comment at: llvm/include/llvm/Transforms/Scalar/Reg2Mem.h:22
+public:
+  RegToMemPass() = default;
+
----------------
delete?


================
Comment at: llvm/test/Transforms/Reg2Mem/crash.ll:1
-; RUN: opt -reg2mem -disable-output -enable-new-pm=0 < %s
+; RUN: opt -reg2mem -disable-output -enable-new-pm=1 < %s
+; RUN: opt -reg2mem -disable-output < %s
----------------
use `-passes=reg2mem` instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91005/new/

https://reviews.llvm.org/D91005



More information about the llvm-commits mailing list