[PATCH] D90830: [OpenMPIRBuilder] Implement CreateCanonicalLoop.
Fady Ghanim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 7 10:25:01 PST 2020
fghanim added a comment.
Thanks for the response, I think I am beginning to understand where this fits.
Just one Nit, O/W LGTM
I am going to wait for @jdoerfert to finish his review, and I'll accept the patch if he doesn't
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:625-639
+/// The control flow can be described as follows:
+///
+/// Preheader
+/// |
+/// /-> Header
+/// | |
+/// | Cond---\
----------------
Thank you for adding this!
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1402
+ assert(size(successors(Cond)) == 2 &&
+ "Exiting block must have tow successors");
+ assert(cast<BranchInst>(Cond->getTerminator())->getSuccessor(0) == Body &&
----------------
Nit: must have **two** successors
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90830/new/
https://reviews.llvm.org/D90830
More information about the llvm-commits
mailing list