[PATCH] D90873: [DWARFLinker] Convert analyzeContextInfo to a work list (NFC)

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 7 02:26:48 PST 2020


avl accepted this revision.
avl added a comment.
This revision is now accepted and ready to land.

LGTM. with small inline comments.



================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:385
+      unsigned ChildIdx = CU.getOrigUnit().getDIEIndex(Child);
+      CompileUnit::DIEInfo &ChildInfo = CU.getInfo(ChildIdx);
+      Worklist.emplace_back(
----------------
CU.getInfo(Child) could be used here.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:393
+
+  unsigned Idx = CU.getOrigUnit().getDIEIndex(DIE);
+  return CU.getInfo(Idx).Prune;
----------------
CU.getInfo(DIE) could be used here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90873/new/

https://reviews.llvm.org/D90873



More information about the llvm-commits mailing list