[PATCH] D88793: [flang] Fix assumptions on std::forward_list iterator implementation.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 21:13:37 PST 2020


Meinersbur added a comment.

In D88793#2312313 <https://reviews.llvm.org/D88793#2312313>, @klausler wrote:

> The point is to use `std::forward_list::splice_after()` for efficient combination of messages.

Unfortunately it also means that we have to search for the new last element since we cannot assume that iterators of the consumed list became iterators for the resulting list. This probably eats up any potations savings. There isn't a a guarantee that splice_after is O(1) anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88793/new/

https://reviews.llvm.org/D88793



More information about the llvm-commits mailing list