[PATCH] D86071: [MLIR][OpenMP] Add omp.wsloop operation

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 11:34:03 PST 2020


kiranchandramohan marked 2 inline comments as done.
kiranchandramohan added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:124-125
+
+    The body region can contain any number of blocks. The region is terminated
+    by "omp.yield" instruction without operands.
+
----------------
ftynse wrote:
> What is the semantics of multiple blocks terminated with `omp.yield` in the loop body?  (Regions are not necessarily single-exit).
The openmp worksharing loop is a single exit region. So multiple terminators are not expected.

Should this be enforced through the verifier in this or a subsequent patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071



More information about the llvm-commits mailing list