[PATCH] D90302: [llvm-reduce] Add reduction for special globals like llvm.used.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 10:09:57 PST 2020


lebedev.ri added a comment.

A nit and a question, but i don't really have an opinion on the functionality here.



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceSpecialGlobals.cpp:24
+
+static auto SpecialGlobalNames = {"llvm.used", "llvm.compiler.used"};
+
----------------
static StringRef


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceSpecialGlobals.cpp:35
+    if (auto *Used = Program->getNamedGlobal(Name)) {
+      Used->replaceAllUsesWith(UndefValue::get(Used->getType()));
+      Used->eraseFromParent();
----------------
Do we want to be more fine-grained than that?
Should this be per-use?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90302/new/

https://reviews.llvm.org/D90302



More information about the llvm-commits mailing list